mirror of
https://github.com/Donchitos/Claude-Code-Game-Studios.git
synced 2026-10-16 09:48:34 +00:00
Release 1.1.2 — the default path works end to end
Fix release for 1.1.1: the minimal path end to end, engine commands that run on Godot, Unity and Unreal, hook warnings you can see, and verdicts that say when they could not check. Details in CHANGELOG.md; upgrade steps in UPGRADING.md (v1.1.1 → v1.1.2). Fixes #67 Fixes #131 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WuJn2FdynEybfL5KC697nJ
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
7ed2c3e9c4
commit
b21fa0f7f2
@@ -6,6 +6,8 @@ Each category defines 4–5 binary PASS/FAIL metrics specific to the skill's job
|
||||
A metric is PASS when the skill's written instructions clearly satisfy the criterion.
|
||||
A metric is FAIL when the instructions are absent, ambiguous, or contradictory.
|
||||
A metric is WARN when the instructions partially address the criterion.
|
||||
A metric is NOT ASSESSED when it could not be evaluated at all — the rubric
|
||||
has no section for the category, or the skill or agent file could not be read.
|
||||
|
||||
---
|
||||
|
||||
@@ -20,11 +22,11 @@ auto-advancing stage and must respect the three review modes.
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **G1 — Review mode read** | Skill reads `production/session-state/review-mode.txt` (or equivalent) before deciding which directors to spawn |
|
||||
| **G2 — Full mode: all 4 directors spawn** | In `full` mode, all 4 Tier-1 directors (CD, TD, PR, AD) PHASE-GATE prompts are invoked in parallel |
|
||||
| **G1 — Review mode read** | Skill reads `review_mode` (and `workflow`) from its resolved config block — `modes.review_mode`, the legacy `production/review-mode.txt`, else the `modes.rigor` value — before deciding which directors to spawn |
|
||||
| **G2 — Director panel width** | Unless `solo`, the PHASE-GATE panel runs in parallel at the width `modes.workflow` sets — `minimal` PR only, `standard` TD + PR, `full` all 4 (CD, TD, PR, AD) — and the output names the perspectives a narrower panel left out |
|
||||
| **G3 — Lean mode: PHASE-GATE only** | In `lean` mode, only `*-PHASE-GATE` gates run; inline gates (CD-PILLARS, TD-ARCHITECTURE, etc.) are skipped |
|
||||
| **G4 — Solo mode: no directors** | In `solo` mode, no director gates spawn; each is noted as "skipped — Solo mode" |
|
||||
| **G5 — No auto-advance** | Skill never writes `production/stage.txt` without explicit user confirmation via "May I write" |
|
||||
| **G5 — No auto-advance** | Skill never writes `project.stage` in `project.yaml`, or the legacy `production/stage.txt`, without explicit user confirmation via a "May I" question |
|
||||
|
||||
---
|
||||
|
||||
@@ -39,13 +41,12 @@ read-only and must not trigger director gates during the analysis phase.
|
||||
|---|---|
|
||||
| **R1 — Read-only enforcement** | Skill does not modify the reviewed document without explicit user approval; any write operations (review logs, index updates) are gated behind "May I write" |
|
||||
| **R2 — 8-section check** | Skill evaluates all 8 required GDD sections (or equivalent architectural sections) explicitly |
|
||||
| **R3 — Correct verdict vocabulary** | Verdict is exactly one of: APPROVED / NEEDS REVISION / MAJOR REVISION NEEDED (design) or PASS / CONCERNS / FAIL (architecture) |
|
||||
| **R4 — No director gates during analysis** | Skill does not spawn director gates during its analysis phases; post-analysis director review (as in architecture-review) is acceptable when the skill's scope and stakes warrant it |
|
||||
| **R3 — Correct verdict vocabulary** | Verdict is exactly one of: APPROVED / NEEDS REVISION / MAJOR REVISION NEEDED / NOT ASSESSED (design-review, ux-review) or PASS / CONCERNS / FAIL / NOT ASSESSED (architecture-review, review-all-gdds) |
|
||||
| **R4 — No director gates during analysis** | Skill does not spawn director gates during its analysis phases; post-analysis director review is acceptable when the skill's scope and stakes warrant it |
|
||||
| **R5 — Structured findings** | Output contains a per-section status table or checklist before the final verdict |
|
||||
|
||||
> **Exceptions:**
|
||||
> - `design-review`: Has `Write, Edit` in allowed-tools to support an optional "Revise now" path (all writes gated behind user approval) and to write review logs. R1 is satisfied because the reviewed document is never silently modified.
|
||||
> - `architecture-review`: Spawns TD-ARCHITECTURE and LP-FEASIBILITY gates after its analysis is complete. This is intentional — architecture review is high-stakes and benefits from director sign-off. R4 is satisfied because the gates run post-analysis, not during it.
|
||||
|
||||
---
|
||||
|
||||
@@ -59,10 +60,10 @@ a single-draft pattern appropriate to their smaller scope.
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **A1 — Section-by-section cycle** | Full authoring skills (design-system, ux-design, art-bible) author one section at a time, presenting content for approval before proceeding to the next. Lightweight skills (quick-design, architecture-decision, create-architecture) may draft the complete document then ask for approval — single-draft is acceptable for documents under ~4 hours of implementation scope. |
|
||||
| **A1 — Section-by-section cycle** | Full authoring skills (design-system, ux-design, art-bible) author one section at a time, presenting content for approval before proceeding to the next. Lightweight skills (quick-design, architecture-decision, create-architecture) may draft the complete document then ask for approval — single-draft is acceptable for documents under about one week of implementation scope. |
|
||||
| **A2 — May-I-write per section** | Full authoring skills ask "May I write this to [filepath]?" before each section write. Lightweight skills ask once for the complete document. |
|
||||
| **A3 — Retrofit mode** | Skill detects if the target file already exists and offers to update specific sections rather than overwriting the whole document. Lightweight skills (quick-design) that always create new files are exempt. |
|
||||
| **A4 — Director gate at correct tier** | If a director gate is defined for this skill (e.g., CD-GDD-ALIGN, TD-ADR), it runs at the correct mode threshold (full/lean) — NOT in solo |
|
||||
| **A4 — Director gate at correct tier** | If a director gate is defined for this skill (e.g., CD-GDD-ALIGN, TD-ADR), it runs in `full` only; in `lean` and `solo` it is skipped with a named note (`[GATE-ID] skipped — Lean mode` / `— Solo mode`) |
|
||||
| **A5 — Skeleton-first** | Full authoring skills create a file skeleton with all section headers before filling content, to preserve progress on session interruption. Lightweight skills are exempt. |
|
||||
|
||||
> **Full authoring skills** (must pass all 5 metrics): `design-system`, `ux-design`, `art-bible`
|
||||
@@ -81,10 +82,10 @@ multi-dimensional verdicts and integrate correctly with director gate mode.
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **RD1 — Multi-dimensional check** | Skill checks ≥3 independent dimensions (e.g., Design, Architecture, Scope, DoD) and reports each separately |
|
||||
| **RD2 — Three verdict levels** | Verdict hierarchy is clearly defined: READY/COMPLETE > NEEDS WORK/COMPLETE WITH NOTES > BLOCKED |
|
||||
| **RD2 — Four verdict levels** | Verdict hierarchy is clearly defined, with NOT ASSESSED between the pass values and the failure values: READY > NOT ASSESSED > NEEDS WORK > BLOCKED (story-readiness); COMPLETE > COMPLETE WITH NOTES > NOT ASSESSED > BLOCKED (story-done) |
|
||||
| **RD3 — BLOCKED requires external action** | BLOCKED verdict is reserved for issues that cannot be fixed by the story author alone (e.g., Proposed ADR, unresolvable dependency) |
|
||||
| **RD4 — Director gate at correct mode** | QL-STORY-READY or LP-CODE-REVIEW gate spawns in `full` mode, skips in `lean`/`solo` with a noted skip message |
|
||||
| **RD5 — Next-story handoff** | After completion, skill surfaces the next READY story from the active sprint |
|
||||
| **RD5 — Next-story handoff** | After completion, skill surfaces the next READY story from the active sprint. With no sprint plan, `/story-done` names the next story in the build order, and `/story-readiness` says no sprint file was found |
|
||||
|
||||
---
|
||||
|
||||
@@ -98,8 +99,8 @@ with correct schema, respect layer/priority ordering, and gate before writing.
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **P1 — Correct output schema** | Each produced file follows the project template (EPIC.md, story frontmatter, etc.); skill references the template path |
|
||||
| **P2 — Layer/priority ordering** | Skills that produce epics or stories respect layer ordering (core → extended → meta) and priority fields |
|
||||
| **P3 — May-I-write before each artifact** | Skill asks "May I write [artifact]?" before creating each output file, not batch-approving all files at once |
|
||||
| **P2 — Layer/priority ordering** | Skills that produce epics or stories respect layer ordering (foundation → core → feature → presentation) and priority fields |
|
||||
| **P3 — May-I-write before each artifact** | Skill asks "May I write …?" before creating output files — one question per file, or one approval that names every file in the changeset; it never writes a file the approval did not name |
|
||||
| **P4 — Director gate at correct tier** | In-scope gates (PR-EPIC, QL-STORY-READY, LP-CODE-REVIEW, etc.) run in `full`, skip in `lean`/`solo` with noted skip |
|
||||
| **P5 — Reads before writes** | Skill reads the relevant GDD/ADR/manifest before producing artifacts to ensure alignment |
|
||||
|
||||
@@ -115,7 +116,7 @@ analysis and must ask before recommending any file writes.
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **AN1 — Read-only scan** | Analysis phase uses only Read/Glob/Grep tools; no Write or Edit during the scan itself |
|
||||
| **AN1 — Read-only scan** | Analysis phase changes nothing: no Write or Edit and no mutating Bash during the scan itself (read-only commands such as `git log` or file-size measurement are fine) |
|
||||
| **AN2 — Structured findings table** | Output includes a findings table or checklist (not prose only) with severity/priority per finding |
|
||||
| **AN3 — No auto-write** | Any suggested file writes (e.g., tech-debt register, fix patches) are gated behind "May I write" |
|
||||
| **AN4 — No director gates during analysis** | Analysis skills do not spawn director gates; they produce findings for human review |
|
||||
@@ -133,10 +134,10 @@ spawn the right agents, run independent ones in parallel, and surface blocks imm
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **T1 — Named agent list** | Skill explicitly names which agents it spawns and in what order |
|
||||
| **T2 — Parallel where independent** | Agents whose inputs don't depend on each other are spawned in parallel (single message, multiple Task calls) |
|
||||
| **T2 — Parallel where independent** | Agents whose inputs don't depend on each other are spawned in parallel (single message, multiple `Agent` calls) |
|
||||
| **T3 — BLOCKED surfacing** | If any spawned agent returns BLOCKED or fails, skill surfaces it immediately and halts dependent work — never silently skips |
|
||||
| **T4 — Collect all verdicts before proceeding** | Dependent phases wait for all parallel agents to complete before proceeding |
|
||||
| **T5 — Usage error on no argument** | If required argument (e.g., feature name) is missing, skill outputs usage hint and stops without spawning agents |
|
||||
| **T5 — Usage error on no argument** | If a required argument (e.g., feature name) is missing, skill either outputs a usage hint and stops, or infers the argument (e.g., the release version, the active sprint) and confirms it with the user — in both cases before spawning any agent |
|
||||
|
||||
---
|
||||
|
||||
@@ -176,7 +177,11 @@ gates, the gate mode logic must also be correct.
|
||||
|
||||
## Agent Categories
|
||||
|
||||
Used to validate agent spec files in `tests/agents/`.
|
||||
Used by `/skill-test category [agent-name]` to evaluate an agent definition in
|
||||
`.claude/agents/` against its category's metrics.
|
||||
|
||||
No category fixes a model. Each agent's tier is its own frontmatter `model:`,
|
||||
and its spec in `agents/` asserts that alias; see `.claude/docs/model-tiers.md`.
|
||||
|
||||
### `director`
|
||||
|
||||
@@ -184,10 +189,9 @@ Used to validate agent spec files in `tests/agents/`.
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **D1 — Correct verdict vocabulary** | Returns APPROVE / CONCERNS / REJECT (or domain equivalent: REALISTIC/CONCERNS/UNREALISTIC for producer) |
|
||||
| **D1 — Correct verdict vocabulary** | Returns `[GATE-ID]: [word]` as its first line, the word taken from the invoked gate's **Verdicts** line — or `NOT ASSESSED`, naming the missing input, when an input the gate names was not given |
|
||||
| **D2 — Domain boundary respected** | Does not make binding decisions outside its declared domain |
|
||||
| **D3 — Conflict escalation** | When two departments conflict, escalates to correct parent (creative-director or technical-director) rather than unilaterally deciding |
|
||||
| **D4 — Opus model tier** | Agent is assigned Opus model per coordination-rules.md |
|
||||
|
||||
### `lead`
|
||||
|
||||
@@ -196,16 +200,15 @@ systems-designer, level-designer
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
| **L1 — Domain verdict** | Returns a domain-specific verdict (e.g., FEASIBLE/INFEASIBLE for lead-programmer, PASS/FAIL for qa-lead) |
|
||||
| **L1 — Gate verdict or findings** | A lead invoked for a gate (lead-programmer's LP-, qa-lead's QL-, narrative-director's ND- gates) returns that gate's **Verdicts** words — or `NOT ASSESSED`, naming a missing input; a lead without a gate returns findings and leaves the verdict to the calling skill |
|
||||
| **L2 — Escalates to shared parent** | Out-of-domain conflicts escalate to creative-director (design) or technical-director (tech) |
|
||||
| **L3 — Sonnet model tier** | Agent is assigned Sonnet model (default) per coordination-rules.md |
|
||||
|
||||
### `specialist`
|
||||
|
||||
**Agents**: gameplay-programmer, ai-programmer, technical-artist, sound-designer,
|
||||
engine-programmer, tools-programmer, network-programmer, security-engineer,
|
||||
accessibility-specialist, ux-designer, ui-programmer, performance-analyst, prototyper,
|
||||
qa-tester, writer, world-builder
|
||||
writer, world-builder
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
@@ -229,7 +232,7 @@ ue-replication-specialist
|
||||
|
||||
### `qa`
|
||||
|
||||
**Agents**: qa-tester, qa-lead, security-engineer, accessibility-specialist
|
||||
**Agents**: qa-tester
|
||||
|
||||
| Metric | PASS criteria |
|
||||
|---|---|
|
||||
@@ -246,4 +249,4 @@ analytics-engineer, economy-designer, localization-lead
|
||||
|---|---|
|
||||
| **O1 — Domain ownership clear** | Agent description clearly states what it owns (pipeline, releases, economy, etc.) |
|
||||
| **O2 — Defers implementation** | Does not write game logic or engine code; delegates to appropriate specialist |
|
||||
| **O3 — Toolset matches role** | `allowed-tools` in frontmatter matches the operational (not coding) nature of the role |
|
||||
| **O3 — Toolset matches role** | `tools:` in frontmatter matches the operational (not coding) nature of the role |
|
||||
|
||||
Reference in New Issue
Block a user