Fix release for 1.1.2: the 14 longest skills keep their later phases after a compaction, a question nobody answered is never taken as an answer, settings read the same from a subfolder, the commit check works for a project in a subfolder of a larger repository, every skill opens with a title, and the shipped allow rules no longer approve deleting a branch or writing files without asking. Details in CHANGELOG.md; upgrade steps in UPGRADING.md (v1.1.2 → v1.1.3). Refs #83 Refs #133 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0185en4t76fPn7315q4c3nko
9.8 KiB
/adopt — Phase 2: Format Audit
Part of
/adopt.SKILL.mdnames when to read this file; the settings it resolved and the rules under its later headings still apply here.
Phase 2: Format Audit
In this file:
- 2a: GDD Format Audit
- 2b: ADR Format Audit
- 2c: systems-index.md Format Audit
- 2d: Story Format Audit
- 2e: Infrastructure Audit
- 2f: Project Config Audit
- 2g: v1.0 Migration Check
For each artifact type in scope (based on argument mode and the resolved
workflow tier), check not just that the file exists but that it contains the
internal structure the template requires. At minimal, scope the audit to
design/game-brief.md — do not audit for GDDs, ADRs, or UX specs (they are not expected).
Steps 2e (the Engine reference row only), 2f (project config) and 2g (v1.0
migration check) run at every tier.
2a: GDD Format Audit
Gather section presence deterministically — do not read the GDDs to count headings. For each GDD discovered in Phase 1, pass its path explicitly to the structure-check script:
Bash: bash .claude/scripts/gdd-structure-check.sh [path-to-gdd]
Pass paths one at a time; do not invoke it bare. The no-argument form sweeps
design/gdd/ only, and a brownfield project's GDDs are not guaranteed to live
there — pass whatever paths Phase 1 found. The script prints a PRESENT: list
and, when applicable, an ABSENT: list per file. It reports presence only
and makes no REQUIRED/ADVISORY judgment (that is the tier logic below), and it
already accepts ## Detailed Design as satisfying the Detailed Rules
requirement, so do not flag that alias as missing.
If the script prints Not found: for a path or errors, that is a discovery
failure, not a format gap — report it as "could not audit [path]" and do not
count it as a missing-sections finding.
Then apply the workflow tier resolved above to each file's PRESENT/ABSENT lists. Which sections are required (a miss = gap) vs advisory (a miss = informational):
full— all 8 sections are required.standard— the 5 required (Overview, Detailed Rules, Edge Cases, Dependencies, Acceptance Criteria) + Formulas for any system that defines numeric rules (rates, curves, thresholds, costs — the system'sCategoryis a hint, not the test); Player Fantasy and Tuning Knobs are advisory.minimal— GDDs are not expected; auditdesign/game-brief.mdinstead, against.claude/docs/templates/game-brief.md: each of the six required fields present and not a placeholder; the three one-liners advisory. Any GDD that does exist is checked at thestandardbar, advisorily.
The script's 8 canonical labels are: Overview, Player Fantasy, Detailed Rules, Formulas, Edge Cases, Dependencies, Tuning Knobs, Acceptance Criteria.
A section reported PRESENT can still be an empty heading. For each GDD, also record with a targeted grep (not a full read):
- Placeholder-only sections —
Grep pattern="\[To be designed\]"(or an equivalent empty/single-line body) marks a present-but-unwritten section. - The
**Status**:header field —Grep pattern="^>?[[:space:]]*\*\*Status\*\*:". Valid values:Draft,In Design,Designed,In Review,Approved,Implemented,Needs Revision.
The
>?is load-bearing, and so areDraft/Implemented. Both emitters write this field inside a blockquote —.claude/docs/templates/game-design-document.mdand/design-systemproduce> **Status**: …— so an anchor of^\*\*Status\*\*:matches nothing and reports every template-compliant GDD as missing its Status. The template's own value list offersDraftandImplemented, so both must count as valid.
2b: ADR Format Audit
For each ADR file found, check for these critical sections:
| Section | Impact if missing |
|---|---|
## Status |
BLOCKING — /story-readiness ADR status check silently passes everything |
## ADR Dependencies |
HIGH — dependency ordering in /architecture-review breaks |
## Engine Compatibility |
HIGH — post-cutoff API risk is unknown |
## GDD Requirements Addressed |
MEDIUM — traceability matrix loses coverage |
## Performance Implications |
LOW — not pipeline-critical |
For each ADR, record: which sections present, which missing, current Status value if the Status section exists.
2c: systems-index.md Format Audit
If design/gdd/systems-index.md exists:
-
Parenthetical status values — Grep for any Status cell containing parentheses:
"Needs Revision (","In Progress (", etc. These break exact-string matching in/gate-check,/create-stories, and/architecture-review. BLOCKING. -
Valid status values — check that Status column values are only from:
Not Started,In Progress,In Review,Designed,Approved,Needs RevisionFlag any unrecognised values. -
Column structure — check that the table has at minimum: System name, Layer, Priority, Status columns. Missing columns degrade skill functionality.
2d: Story Format Audit
For each story file found:
Manifest Version:field — present in story header? (LOW — auto-passes if absent)- TR-ID reference — does story contain
TR-[a-z]+-[0-9]+pattern? (MEDIUM — no staleness tracking) - ADR reference — does story reference at least one ADR? (check for
ADR-pattern) - Status field — present and readable?
- Acceptance criteria — does the story have a checkbox list (
- [ ])?
2e: Infrastructure Audit
| Artifact | Path | Impact if missing |
|---|---|---|
| TR registry | docs/architecture/tr-registry.yaml |
HIGH — no stable requirement IDs |
| Control manifest | docs/architecture/control-manifest.md |
HIGH — no layer rules for stories |
| Manifest version stamp | In manifest header: Manifest Version: |
MEDIUM — staleness checks blind |
| Sprint status | production/sprint-status.yaml |
MEDIUM — /sprint-status falls back to markdown |
| Stage file | project.stage in project.yaml (fallback production/stage.txt) |
MEDIUM — phase auto-detect unreliable |
| Engine reference | docs/engine-reference/[engine]/VERSION.md |
HIGH — ADR engine checks blind |
| Architecture traceability | docs/architecture/requirements-traceability.md |
MEDIUM — no persistent matrix |
At workflow: minimal only the Engine reference row applies. The TR registry,
control manifest and its version stamp, sprint status, stage file and
traceability matrix are not on the minimal path, so their absence is not a gap.
2f: Project Config Audit
Read project.yaml (the primary config store) and .claude/docs/technical-preferences.md (legacy mirror). A setting counts as configured if EITHER source has a real value (in technical-preferences.md, [TO BE CONFIGURED] means unconfigured):
engine.name/version/language/rendering/physics(else the Engine/Language/Rendering/Physics fields) → HIGH if unconfigured in both (ADR skills fail)naming.*(else Naming conventions) → MEDIUMperformance.*(else Performance budgets) → MEDIUM- Forbidden Patterns, Allowed Libraries (technical-preferences.md only — not migrated to project.yaml) → LOW (starts empty by design)
2g: v1.0 Migration Check
A project is a v1.0 project needing migration when project.yaml does NOT
exist at the repo root AND at least one legacy file does: production/stage.txt,
production/review-mode.txt, or a .claude/docs/technical-preferences.md with
real values.
"Real values" means one of the keys the converter actually migrates — Engine,
Language, Rendering, Physics, the naming, platform and performance fields,
Framework, or the specialists. Not merely "some bullet is filled in": the
shipped template ships one prose default (- **Required Tests**: …) that is
never migrated, and counting it made every fresh clone read as a v1.0 project.
Do not hand-migrate. Run the converter, which is deterministic and covered by the framework's own test suite:
bash .claude/scripts/migrate-v1-config.sh --dry-run
The dry run writes nothing; record what it lists for the report. Do not run the
converter during the audit — Phase 2 reads silently. The migration is
classified BLOCKING in Phase 3, heads the plan, and Phase 7 offers it as the
first action: report what the dry run listed, then ask "May I run the
converter? It writes project.yaml and production/migration-report.md." If
the user approves, run it without --dry-run. It
writes project.yaml plus production/migration-report.md and deletes
nothing — the whole operation stays reversible with git checkout.
Then tell the user to read production/migration-report.md before running:
bash .claude/scripts/migrate-v1-config.sh --finalize
--finalize deletes a legacy file only after proving its value is present in
project.yaml; on mismatch it deletes nothing and exits 4. It never deletes
technical-preferences.md, which still holds Forbidden Patterns and Allowed
Libraries.
If the script refuses with exit 3, do not work around it. Exit 3 means one of two things, and the message says which:
- the values DISAGREE — two sources of truth and no way to know which the user edited last. Surface it and let them decide.
- a
production/migration-report.mdis already present — a migration ran here, so these are post-migration leftovers and--finalizeis the next step, not a secondmigrate.
Both files merely existing is not exit 3 and must not be reported as a
conflict: /start writes production/stage.txt on every new v1.1 project as a
mirror, so agreement is the normal state. The script says
the legacy files mirror it (values agree) and exits 0 for that.
Classify as BLOCKING in Phase 3: until migration runs, every skill reads config through the legacy fallback chain, and v1.1 settings are unavailable.